Skip to content

DSR 1.01 compat (#72) #488

DSR 1.01 compat (#72)

DSR 1.01 compat (#72) #488

GitHub Actions / Qodana for .NET completed Dec 30, 2024 in 0s

324 new problems found by Qodana for .NET

Qodana for .NET

324 new problems were found

Inspection name Severity Problems
Redundant member initializer 🔶 Warning 46
Method return value is never used (private accessibility) 🔶 Warning 34
Redundant cast 🔶 Warning 31
Redundant name qualifier 🔶 Warning 26
Unresolved binding path when DataContext is known 🔶 Warning 23
Assignment is not used 🔶 Warning 22
Redundant class or interface specification in base types list 🔶 Warning 13
Unused local variable 🔶 Warning 13
Possible 'null' assignment to non-nullable entity 🔶 Warning 11
Possible 'System.InvalidOperationException' 🔶 Warning 11
Type member is never used (private accessibility) 🔶 Warning 10
Redundant namespace alias 🔶 Warning 10
Function never returns 🔶 Warning 7
Non-accessed local variable 🔶 Warning 7
Access to a static member of a type via a derived type 🔶 Warning 6
Redundant explicit type in array creation 🔶 Warning 6
Redundant resource 🔶 Warning 6
Invalid XML documentation comment 🔶 Warning 5
Redundant using directive 🔶 Warning 5
Redundant control flow jump statement 🔶 Warning 4
Possible 'System.NullReferenceException' 🔶 Warning 3
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 3
Remove redundant attached property setter 🔶 Warning 3
Namespace does not correspond to file location 🔶 Warning 2
Private field can be converted into local variable 🔶 Warning 2
Redundant operand in logical conditional expression 🔶 Warning 2
Unused parameter (private accessibility) 🔶 Warning 2
Collection content is never queried (non-private accessibility) 🔶 Warning 1
Expression is always 'true' or always 'false' 🔶 Warning 1
Empty constructor 🔶 Warning 1
Empty statement is redundant 🔶 Warning 1
Expression is always 'null' 🔶 Warning 1
Return value of [MustUseReturnValue] annotated method is not used 🔶 Warning 1
Non-accessed field (private accessibility) 🔶 Warning 1
Redundant lambda expression parameter type specification 🔶 Warning 1
Redundant 'object.ToString()' call 🔶 Warning 1
Grid element column/row index is out of grid definition range 🔶 Warning 1
Missing grid column/row setter for non-first child 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 5 dependencies

Third-party software list

This page lists the third-party software dependencies used in SoulSplitter

Dependency Version Licenses
MaterialDesignColors 2.1.4 MIT
MaterialDesignThemes 4.9.0 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.NETCore.Platforms 1.1.0 MIT
Microsoft.Xaml.Behaviors.Wpf 1.1.39 MIT
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 217 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 231 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 91 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 105 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 123 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 77 in src/SoulSplitter/Migrations/Migrator.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Access to a static member of a type via a derived type

Access to a static member of a type via a derived type

Check warning on line 81 in src/SoulSplitter/soulmemory-rs/SoulMemoryRs.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 392 in src/SoulSplitter/SoulComponent.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 37 in tests/SoulSplitter.Tests/Integration/SoulsComponentTestWrapper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 132 in src/SoulMemory/soulmods/Soulmods.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 49 in src/SoulMemory/Memory/Extensions.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 33 in src/SoulMemory/Memory/Extensions.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 50 in src/SoulSplitter/Logger.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 65 in src/SoulMemory/Memory/Extensions.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 37 in tests/SoulSplitter.Tests/Integration/SoulsComponentTestWrapper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 37 in tests/SoulSplitter.Tests/Integration/SoulsComponentTestWrapper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 37 in tests/SoulSplitter.Tests/Integration/SoulsComponentTestWrapper.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Possible 'null' assignment to non-nullable entity

Possible 'null' assignment to non-nullable entity

Check warning on line 22 in src/SoulSplitter/UI/ErrorViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Namespace does not correspond to file location

Namespace does not correspond to file location, must be: 'SoulSplitter.UI'

Check warning on line 20 in tests/SoulSplitter.Tests/TestMethodSTAAttribute.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Namespace does not correspond to file location

Namespace does not correspond to file location, must be: 'SoulSplitter.Tests'

Check warning on line 107 in tests/SoulMemory.Tests/Mocks/ProcessHookMock.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Collection content is never queried (non-private accessibility)

Content of collection 'ExitedExceptions' is only updated but never used

Check warning on line 183 in src/SoulSplitter/Splitters/DarkSouls1Splitter.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'true' or always 'false'

Expression is always true

Check warning on line 32 in src/SoulSplitter/UI/EldenRing/EldenRingViewModel.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Empty constructor

Empty constructor is redundant. The compiler generates the same by default.

Check warning on line 65 in tests/SoulMemory.Tests/RefreshErrorTests.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Empty statement is redundant

Empty statement is redundant

Check warning on line 56 in src/SoulMemory/DarkSouls1/Sl2Reader.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Expression is always 'null'

Expression is always null

Check warning on line 340 in src/CliTimer/Program.cs

See this annotation in the file changed.

@github-actions github-actions / Qodana for .NET

Function never returns

Function never returns