Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkey picker #65
base: main
Are you sure you want to change the base?
Hotkey picker #65
Changes from all commits
de1d241
8e9bc47
99ec4ff
92db7dd
7d7a47c
05486ff
c0952a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 29 in src/SoulSplitter/Hotkeys/GlobalHotKey.cs
GitHub Actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Check notice on line 30 in src/SoulSplitter/Hotkeys/GlobalHotKey.cs
GitHub Actions / Qodana for .NET
Use preferred style of 'new' expression when created type is evident
Check notice on line 112 in src/SoulSplitter/Hotkeys/GlobalHotKey.cs
GitHub Actions / Qodana for .NET
Redundant empty argument list on object creation expression
Check warning on line 17 in src/SoulSplitter/Hotkeys/Hotkey.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 18 in src/SoulSplitter/Hotkeys/Hotkey.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 19 in src/SoulSplitter/Hotkeys/Hotkey.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 20 in src/SoulSplitter/Hotkeys/Hotkey.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 21 in src/SoulSplitter/Hotkeys/Hotkey.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 18 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check warning on line 24 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Redundant using directive
Check warning
Code scanning / QDNET
Redundant using directive Warning
Check notice on line 32 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Field can be made readonly (private accessibility)
Check warning on line 34 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Nullability conflicts with annotations in hierarchy
Check warning on line 34 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Nullability conflicts with annotations in hierarchy
Check warning
Code scanning / QDNET
Nullability conflicts with annotations in hierarchy Warning
Check warning
Code scanning / QDNET
Nullability conflicts with annotations in hierarchy Warning
Check notice on line 36 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Invert 'if' statement to reduce nesting
Check notice on line 39 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used
Check notice on line 41 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Invert 'if' statement to reduce nesting
Check warning on line 54 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Nullability conflicts with annotations in hierarchy
Check warning on line 54 in src/SoulSplitter/UI/Converters/HotkeyToStringConverter.cs
GitHub Actions / Qodana for .NET
Nullability conflicts with annotations in hierarchy
Check warning
Code scanning / QDNET
Nullability conflicts with annotations in hierarchy Warning
Check warning
Code scanning / QDNET
Nullability conflicts with annotations in hierarchy Warning