Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Implement MultiSig signing #100

Closed
FrankC01 opened this issue May 2, 2023 · 0 comments
Closed

[enhancement] Implement MultiSig signing #100

FrankC01 opened this issue May 2, 2023 · 0 comments
Assignees
@FrankC01
Labels
enhancement New feature or request

Comments

@FrankC01
Copy link
Owner

FrankC01 commented May 2, 2023

Currently, for signing, pysui does a subprocess to sui keytool multi-sig-combine-partial-sig.

This was a time to market decision.

This enhancement will perform signing in core and have 1 less dependency on Sui binaries.
@FrankC01 FrankC01 added the enhancement New feature or request label May 2, 2023
@FrankC01 FrankC01 self-assigned this May 2, 2023
@FrankC01 FrankC01 added this to pysui May 2, 2023
@github-project-automation github-project-automation bot moved this to Backlog in pysui May 2, 2023
@FrankC01 FrankC01 moved this from Backlog to In Progress in pysui May 8, 2023
FrankC01 added a commit that referenced this issue May 9, 2023
@FrankC01
Closes #100, #109
0d47e02
@github-project-automation github-project-automation bot moved this from In Progress to Done in pysui May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankC01 FrankC01

Labels
enhancement New feature or request
Projects
pysui
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FrankC01