Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Delphi 12 Community Edition #718

Open
BrooksV opened this issue Dec 14, 2024 · 4 comments
Open

Support for Delphi 12 Community Edition #718

BrooksV opened this issue Dec 14, 2024 · 4 comments

Comments

@BrooksV
Copy link

BrooksV commented Dec 14, 2024

Hi Frank,

I spent the past few days installing and setting up the Community Edition of Delphi 12 Version 29.0.51961.7529 and ExifToolsGui 3.6.3 from GitHub.

I ran into a minor snag involving styles and the lack of the VCL Metropolis UI vsf files. Delphi 12 seems only to have the FireMonkey Metropolis UI .style files.

Not sure what the correct way to resolve the issue.

I did a work-around by adding uses FMX.Styles, FMX.Types, where Vcl.Themes, Vcl.Styles, existed and to prefix TStyleManager with Vcl.Themes.TStyleManager.

  • Brooks
@FrankBijnen
Copy link
Owner

Hi Brooks,

See you've added a 'few' issues. I'll try to answer them 1 by 1.

I have no experience with Delphi 12. It's on my list to get involved, just a lack of time.

'Somehow' these styles have found their way into my development system. As I understand they are for FMX and not VCL. (FMX uses .style and VCL uses .vsf) I happen to have .vsf files, likely from a previous Delphi version.
The best thing to do is not use them, but I fear that existing users may run in to problems.
Will look into it when I get Delphi 12. Keep this open please.

Frank

@BrooksV
Copy link
Author

BrooksV commented Dec 18, 2024

The only issue I had with building using Delphi 12 was that the VCL Metropolis UI vsf files were not provided with Delphi 12.

I did find and downloaded the VSF files from the GitHub Delphi Styles Project.

I placed them in the C:\Users\Public\Documents\Embarcadero\Studio\23.0\Styles folder along with ..\ExifToolGui\Styles files as described in the ExifToolGui Styles ReadMe.txt file. Note the Delphi 12 is in the \23.0\ folder and not the \22.0\ used for Delphi 11.x.

https://github.com/RRUZ/vcl-styles-utils/tree/master/Demos/Styles

@FrankBijnen
Copy link
Owner

So the good new is, that the code can easily be upgraded to Delphi 12?

I like to think that is partly because I'm not using (closed source) 3rd party libraries. In my view all source code should be in the repository. (I will get back to this when it comes to using DB's)

@FrankBijnen
Copy link
Owner

Hi Brooks,

I have added a remark to the readme in the Styles directory, with a link where the metropolis styles can be downloaded.
In addition I have updated the dproj files, and fixed the column header in the shelllist when using column sorting,

Please dont close the issue, I will do that when V6.3.7 is released.

Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants