Skip to content

Commit

Permalink
testing: move NoopClientCall & NoopServerCall to internal
Browse files Browse the repository at this point in the history
one step for grpc#3105
  • Loading branch information
dapengzhang0 authored Jun 22, 2017
1 parent 6d9e149 commit b7e50dd
Show file tree
Hide file tree
Showing 9 changed files with 126 additions and 7 deletions.
2 changes: 1 addition & 1 deletion core/src/test/java/io/grpc/ContextsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
import static org.junit.Assert.fail;

import io.grpc.internal.FakeClock;
import io.grpc.testing.NoopServerCall;
import io.grpc.internal.NoopServerCall;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
Expand Down
2 changes: 1 addition & 1 deletion core/src/test/java/io/grpc/ServerInterceptorsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import io.grpc.MethodDescriptor.Marshaller;
import io.grpc.MethodDescriptor.MethodType;
import io.grpc.ServerCall.Listener;
import io.grpc.testing.NoopServerCall;
import io.grpc.internal.NoopServerCall;
import java.io.ByteArrayInputStream;
import java.io.InputStream;
import java.util.ArrayList;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import io.grpc.ServiceDescriptor;
import io.grpc.Status;
import io.grpc.StatusRuntimeException;
import io.grpc.testing.NoopServerCall;
import io.grpc.internal.NoopServerCall;
import io.grpc.testing.TestMethodDescriptors;
import java.util.Arrays;
import org.junit.Test;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
import io.grpc.ClientCall;
import io.grpc.Deadline;
import io.grpc.MethodDescriptor;
import io.grpc.testing.NoopClientCall;
import io.grpc.internal.NoopClientCall;
import io.grpc.testing.integration.Messages.SimpleRequest;
import io.grpc.testing.integration.Messages.SimpleResponse;
import io.grpc.testing.integration.TestServiceGrpc;
Expand Down
2 changes: 1 addition & 1 deletion stub/src/test/java/io/grpc/stub/ClientCallsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
import io.grpc.StatusRuntimeException;
import io.grpc.inprocess.InProcessChannelBuilder;
import io.grpc.inprocess.InProcessServerBuilder;
import io.grpc.internal.NoopClientCall;
import io.grpc.stub.ServerCalls.NoopStreamObserver;
import io.grpc.stub.ServerCallsTest.IntegerMarshaller;
import io.grpc.testing.NoopClientCall;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Iterator;
Expand Down
51 changes: 51 additions & 0 deletions testing/src/main/java/io/grpc/internal/NoopClientCall.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/*
* Copyright 2016, gRPC Authors All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc.internal;

import io.grpc.ClientCall;
import io.grpc.Metadata;

/**
* {@link NoopClientCall} is a class that is designed for use in tests. It is designed to be used
* in places where a scriptable call is necessary. By default, all methods are noops, and designed
* to be overriden.
*/
public class NoopClientCall<ReqT, RespT> extends ClientCall<ReqT, RespT> {

/**
* {@link NoopClientCall.NoopClientCallListener} is a class that is designed for use in tests.
* It is designed to be used in places where a scriptable call listener is necessary. By
* default, all methods are noops, and designed to be overriden.
*/
public static class NoopClientCallListener<T> extends ClientCall.Listener<T> {
}

@Override
public void start(ClientCall.Listener<RespT> listener, Metadata headers) {}

@Override
public void request(int numMessages) {}

@Override
public void cancel(String message, Throwable cause) {}

@Override
public void halfClose() {}

@Override
public void sendMessage(ReqT message) {}
}
60 changes: 60 additions & 0 deletions testing/src/main/java/io/grpc/internal/NoopServerCall.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
* Copyright 2016, gRPC Authors All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.grpc.internal;

import io.grpc.Metadata;
import io.grpc.MethodDescriptor;
import io.grpc.ServerCall;
import io.grpc.Status;

/**
* {@link NoopServerCall} is a class that is designed for use in tests. It is designed to be used
* in places where a scriptable call is necessary. By default, all methods are noops, and designed
* to be overriden.
*/
public class NoopServerCall<ReqT, RespT> extends ServerCall<ReqT, RespT> {

/**
* {@link NoopServerCall.NoopServerCallListener} is a class that is designed for use in tests.
* It is designed to be used in places where a scriptable call listener is necessary. By
* default, all methods are noops, and designed to be overriden.
*/
public static class NoopServerCallListener<T> extends ServerCall.Listener<T> {
}

@Override
public void request(int numMessages) {}

@Override
public void sendHeaders(Metadata headers) {}

@Override
public void sendMessage(RespT message) {}

@Override
public void close(Status status, Metadata trailers) {}

@Override
public boolean isCancelled() {
return false;
}

@Override
public MethodDescriptor<ReqT, RespT> getMethodDescriptor() {
return null;
}
}
6 changes: 5 additions & 1 deletion testing/src/main/java/io/grpc/testing/NoopClientCall.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@
* {@link NoopClientCall} is a class that is designed for use in tests. It is designed to be used
* in places where a scriptable call is necessary. By default, all methods are noops, and designed
* to be overriden.
*
* @deprecated moved to {@link io.grpc.internal.NoopClientCall} and for internal use only. Please
* use {@link GrpcServerRule} to test on InProcess channels instead
*/
@Deprecated
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/2234")
public class NoopClientCall<ReqT, RespT> extends ClientCall<ReqT, RespT> {

Expand All @@ -33,6 +37,7 @@ public class NoopClientCall<ReqT, RespT> extends ClientCall<ReqT, RespT> {
* It is designed to be used in places where a scriptable call listener is necessary. By
* default, all methods are noops, and designed to be overriden.
*/
@Deprecated
public static class NoopClientCallListener<T> extends ClientCall.Listener<T> {
}

Expand All @@ -51,4 +56,3 @@ public void halfClose() {}
@Override
public void sendMessage(ReqT message) {}
}

6 changes: 5 additions & 1 deletion testing/src/main/java/io/grpc/testing/NoopServerCall.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@
* {@link NoopServerCall} is a class that is designed for use in tests. It is designed to be used
* in places where a scriptable call is necessary. By default, all methods are noops, and designed
* to be overriden.
*
* @deprecated moved to {@link io.grpc.internal.NoopServerCall} and for internal use only. Please
* use {@link GrpcServerRule} to test on InProcess channels instead
*/
@Deprecated
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/2234")
public class NoopServerCall<ReqT, RespT> extends ServerCall<ReqT, RespT> {

Expand All @@ -35,6 +39,7 @@ public class NoopServerCall<ReqT, RespT> extends ServerCall<ReqT, RespT> {
* It is designed to be used in places where a scriptable call listener is necessary. By
* default, all methods are noops, and designed to be overriden.
*/
@Deprecated
public static class NoopServerCallListener<T> extends ServerCall.Listener<T> {
}

Expand All @@ -60,4 +65,3 @@ public MethodDescriptor<ReqT, RespT> getMethodDescriptor() {
return null;
}
}

0 comments on commit b7e50dd

Please sign in to comment.