sanity check on fix for #92 #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey! Offhand I think this looks great - is |
|
@bengotow I presume it is, that line is modified because I had to add a |
|
Closed in favor of #179 but thank you for reviewing that one! |
This was referenced Sep 23, 2022
This was referenced Sep 25, 2022
This was referenced Oct 1, 2022
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bengotow not to waste your time, but I need a bit to figure out how to spin up a working environment on WSL for Mailspring and I wanted to sanity check my implementation of #92. If it works, I'd love to be able to fix my own problems with #169.