Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar preview only shows empty screen #1492

Closed
mslourens opened this issue May 8, 2019 · 11 comments
Closed

Calendar preview only shows empty screen #1492

mslourens opened this issue May 8, 2019 · 11 comments

Comments

@mslourens
Copy link
Contributor

What operating system are you using?
Linux Mint 19.1

What version of Mailspring are you using?
1.6.1

Steps to reproduce:
Prerequisites: Create GMail account

  1. Click Developer -> Calendar Preview
  2. An empty calendar window opens (without any chrome, like a close button)

Way to fix the bug
I've cloned the repository and debugged the application. There are two reasons the Calendar Preview window is empty:

  1. The file calendar-wrapper.ts (in interal_packages/main-calendar/lib/core) is importing the class MailspringCalendar from './core/mailspring-calendar'; (on line 8), but there is no file called mailspring-calendar.tsx. You have to rename nylas-calendar.tsx to mailspring-calendar.tsx (or change the import).
  2. The file calendar-toggles.tsz (in interal_packages/main-calendar/lib/core) is checking for disabledCalendars to contain the current calendar.id but the prop is undefined. To fix this issue you have to either check if the property exist or give it an empty value in the config (where it comes from).
@bengotow
Copy link
Collaborator

bengotow commented May 26, 2019

Hey @mslourens—wow, thanks for reporting this and diagnosing the issue! It looks like I broke this right at the end of the typescript conversion by renaming a few things. I'll get this fixed in the next release! I've been working on the sync logic for the calendar feature and the preview should be getting more fun soon - stay tuned!

@ransagy
Copy link

ransagy commented Jun 18, 2019

@bengotow This still happens on 1.6.2 for me - None of my 3 gmail accounts (one is a gapps/gsuite work account) show anything on the preview screen.

@mslourens
Copy link
Contributor Author

mslourens commented Jun 24, 2019

fixed by version 1.6.2 for me

@ransagy
Copy link

ransagy commented Jul 2, 2019

@mslourens did you mean 1.6.2?

Either way, Still the same for me on 1.6.3. The sidebar loads and shows the various event categories, but nothing actually appears in the calendar itself.

@mslourens
Copy link
Contributor Author

@ransagy Yes, I meant 1.6.2, sorry about the confusion.
Do you see any errors in the developer tools, if you open them by going to Developer => Toggle Developer Tools or press CTRL+ALT+I?

@ransagy
Copy link

ransagy commented Jul 2, 2019

Nope, first thing i checked. Just debug info about querying the event data store.

@bengotow
Copy link
Collaborator

bengotow commented Jul 4, 2019

Hey folks—thanks for the updates here. It looks like we've gotten some automated JS exceptions reported from the calendar preview in the latest release, so I'll see if I can get this fixed. Starting in the next month or so you'll be able to create / edit calendar events as well and this should get a whole lot more polished. Stay tuned!

@bengotow
Copy link
Collaborator

Hey folks, thanks for reporting this. Happy to say this has been resolved in a recent release and 1.7.6, which shipped today, should leave things in a nice stable place while I go and finish the calendar feature. Stay tuned!

@keith-collyer
Copy link

For me, the calendar preview shows a list of my Google calendars, but the calendar itself is blank.
Mailspring 1.9.2-6e14dad1
Windows 10 Home 21H2 build 19044.1466

@keith-collyer
Copy link

The main display is out of sync with the mini-calendar showing the month when I Maximize the window, it's fine in the normal size. So right now the mini-calendar is showing the month of January, with today (25) highlighted. The main display shows that week starting on Sunday, the same as the mini-calendar, with today highlighted. When I maximize, the mini-calendar stays the same, but the main display now shows a week ending on the 25th - actually only part of the day, and the left-hand end has part of the previous Tuesday showing.
Mailspring 1.9.2-6e14dad1
Windows 10 Home 21H2 build 19044.1466

@foundry376-bot
Copy link

This issue has been mentioned on Mailspring Community. There might be relevant details there:

https://community.getmailspring.com/t/calendar-support/85/19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants