-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safety checks for inclusion and improve the exclusion check #1971
Merged
johscheuer
merged 7 commits into
FoundationDB:main
from
johscheuer:check-if-inclusion-is-safe
Mar 16, 2024
Merged
Add safety checks for inclusion and improve the exclusion check #1971
johscheuer
merged 7 commits into
FoundationDB:main
from
johscheuer:check-if-inclusion-is-safe
Mar 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Not surprising that the tests are timing out as we added additional wait time. |
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Mar 15, 2024
nicmorales9
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just comment-comments, as usual, functionality looks good!
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
…ime and make sure exclude and include calls are coordinated
* Initial changes for new maintenance mode integration
…ime and make sure exclude and include calls are coordinated
johscheuer
force-pushed
the
check-if-inclusion-is-safe
branch
from
March 15, 2024 16:30
7068292
to
823a076
Compare
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the safety check around exclusions and add a safety check for inclusions. This should reduce the risk of repeated recoveries because of the operator.
Type of change
Please select one of the options below.
Discussion
Testing
Unit tests and the e2e test will be running by CI.
Documentation
Will be updated.
Follow-up