Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a cluster name in test suite #1946

Conversation

johscheuer
Copy link
Member

Description

Depending on the test case it would be useful to reuse a cluster, e.g. in cases where a test cluster gets loaded with some amount of data.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Are there any design details that you would like to discuss further?

Testing

Ran a manual test:

NAMESPACE=jdev CLUSTER_NAME=jdev  make -C e2e test_operator.run

With the following cluster and Pods created (the cluster is not available as the data loader is active):

$ kubectl -n jdev get fdb,po 
NAME                                             GENERATION   RECONCILED   AVAILABLE   FULLREPLICATION   VERSION   AGE
foundationdbcluster.apps.foundationdb.org/jdev   1                                                       7.1.53    4m46s

NAME                                                              READY   STATUS    RESTARTS   AGE
pod/jdev-log-1                                                    2/2     Running   0          4m45s
pod/jdev-log-2                                                    2/2     Running   0          4m45s
pod/jdev-log-3                                                    2/2     Running   0          4m45s
pod/jdev-log-4                                                    2/2     Running   0          4m45s
pod/jdev-log-5                                                    2/2     Running   0          4m45s
pod/jdev-stateless-1                                              2/2     Running   0          4m45s
pod/jdev-stateless-2                                              2/2     Running   0          4m45s
pod/jdev-stateless-3                                              2/2     Running   0          4m45s
pod/jdev-stateless-4                                              2/2     Running   0          4m45s
pod/jdev-stateless-5                                              2/2     Running   0          4m45s
pod/jdev-stateless-6                                              2/2     Running   0          4m45s
pod/jdev-stateless-7                                              2/2     Running   0          4m45s
...

Documentation

Added

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 874082f
  • Duration 1:43:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, if it works in your tests then ship it 😄

@johscheuer johscheuer merged commit b9566b4 into FoundationDB:main Feb 22, 2024
8 checks passed
@johscheuer johscheuer deleted the allow-to-specify-cluster-name-test-suite branch February 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants