Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't skip the exclusion for process groups without an address when using localities #1938

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1890

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Added an additional test and CI will run e2e tests.

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9a92392
  • Duration 1:43:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! I'll leave the comment suggestion up to you

internal/replacements/replace_failed_process_groups.go Outdated Show resolved Hide resolved
@johscheuer johscheuer merged commit 85b510f into FoundationDB:main Feb 14, 2024
7 of 8 checks passed
@johscheuer johscheuer deleted the dont-skip-exclusion-locality branch February 14, 2024 13:15
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 1efcc61
  • Duration 1:59:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacement of failed processes without and address with locality-based exclusions
3 participants