Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the remove sub command to remove by process class #1935

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

nicmorales9
Copy link
Contributor

Description

This addresses #1702

Type of change

  • New feature (non-breaking change which adds functionality)

Discussion

Let me know if the error raising is undesirable, also if a struct of common options for these commands might be helpful instead of the long list of parameters/options that includes many naked bools.

Testing

*Please describe the tests that you ran to verify your changes. Unit tests?
Unit tests are in the PR and I tested it on some actual pods

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
I do not believe so, no.

Documentation

Did you update relevant documentation within this repository?
I don't think this is needed beyond the docstrings

If this change is adding new functionality, do we need to describe it in our user manual?
I do not think so, no

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?
N/A

Follow-up

Are there any follow-up issues that we should pursue in the future?
No

Does this introduce new defaults that we should re-evaluate in the future?
No

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: d7b2ea1
  • Duration 1:44:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: dcd6344
  • Duration 2:03:08
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kubectl-fdb/cmd/remove_process_group.go Show resolved Hide resolved
kubectl-fdb/cmd/remove_process_group.go Show resolved Hide resolved
kubectl-fdb/cmd/remove_process_group_test.go Show resolved Hide resolved
@johscheuer johscheuer merged commit f4b2fe2 into FoundationDB:main Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants