Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the way how the client knobs are passed down and used #1731

Merged

Conversation

johscheuer
Copy link
Member

Description

Fix the way we handled the client knobs (we want to set them for backup and restore calls).

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Corrected the unit test setup.

Documentation

Follow-up

@johscheuer johscheuer added the bug Something isn't working label Jul 7, 2023
go.mod Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2e5847b
  • Duration 2:23:46
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 85a7d7f
  • Duration 3:25:40
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jul 7, 2023
@johscheuer johscheuer reopened this Jul 7, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 85a7d7f
  • Duration 3:31:16
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jul 11, 2023
@johscheuer johscheuer reopened this Jul 11, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 85a7d7f
  • Duration 3:43:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 525e6b3 into FoundationDB:main Jul 12, 2023
@johscheuer johscheuer deleted the correct-knob-handling-backups branch July 12, 2023 13:59
johscheuer added a commit to johscheuer/fdb-kubernetes-operator that referenced this pull request Aug 2, 2023
…tionDB#1731)

* Correct the way how the client knobs are passed down and used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants