Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure mock k8s client implements controller runtime client #1700

Conversation

johscheuer
Copy link
Member

Description

Make sure our Mock k8s client implements the controller runtime client.WithWatch interface.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Unit tests.

Documentation

Follow-up

@johscheuer johscheuer merged commit 0d35550 into FoundationDB:main Jun 22, 2023
@johscheuer johscheuer deleted the make-sure-mock-k8s-client-implements-controller-client branch June 22, 2023 15:27
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: c4812ab
  • Duration 2:20:07
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

  • Commit ID: c4812ab
  • Duration 4:08:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants