Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in analyze command if cluster is not found #1697

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1693

Thanks @masih for reporting

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Testing

Did a local test with the fix:

$ ./dist/kubectl-fdb_darwin_arm64/kubectl-fdb analyze tabaluga
Error:
could not fetch cluster information for: default/tabaluga, error: foundationdbclusters.apps.foundationdb.org "tabaluga" not found

Documentation

Follow-up

@johscheuer johscheuer added bug Something isn't working plugin Kubectl plugin labels Jun 22, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

  • Commit ID: b0bb5e7
  • Duration 0:05:47
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C e2e kind-setup. Reason: exit status 2
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b0bb5e7
  • Duration 2:15:32
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer changed the title Fix panic in analyze command if cluter is not fund Fix panic in analyze command if cluster is not found Jun 22, 2023
@johscheuer johscheuer merged commit 752d841 into FoundationDB:main Jun 22, 2023
@johscheuer johscheuer deleted the fix-panic-analyze-command branch June 22, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Kubectl plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix panic caused by analyzing a cluster that is not found
3 participants