Add prefix factory option

[flowguru]

This allows us to re-use existing clusters and can greatly fasten the testing time.

Description

Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation
• Other

Discussion

Are there any design details that you would like to discuss further?

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 15c0c7e
• Duration 2:17:15
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

• Commit ID: 15c0c7e
• Duration 4:07:39
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[flowguru]

I have tested it with replace github.com/FoundationDB/fdb-kubernetes-operator => /root/src/fdb-kubernetes-operator in go.mod, it works now.

[johscheuer]

Changes LGTM, can we add this to the Makefile: https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/e2e/Makefile#L10-L33 to allow users to use this option?

[flowguru]

sure, added

[johscheuer]

Thanks 👍

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: 34e01e3
• Duration 0:06:47
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

• Commit ID: 34e01e3
• Duration 0:07:50
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[flowguru]

from log I saw the error below, trying to see how this is related

[BeforeSuite] 
/codebuild/output/src39755650/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:86
  [FAILED] in [BeforeSuite] - /codebuild/output/src39755650/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/factory.go:67 @ 06/23/23 14:40:44.294
[BeforeSuite] [FAILED] [0.000 seconds]
[BeforeSuite] 
/codebuild/output/src39755650/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/test_operator/operator_test.go:86

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc000510490>: {
          s: "no fdb image is supplied",
      }
      no fdb image is supplied
  occurred
  In [BeforeSuite] at: /codebuild/output/src39755650/src/github.com/FoundationDB/fdb-kubernetes-operator/e2e/fixtures/factory.go:67 @ 06/23/23 14:40:44.294

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

• Commit ID: aae8ea7
• Duration 2:24:02
• Result: ✅ SUCCEEDED
• Error: N/A
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)

[foundationdb-ci]

Result of fdb-kubernetes-operator-pr-kind on Linux CentOS 7

• Commit ID: aae8ea7
• Duration 4:07:03
• Result: ❌ FAILED
• Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
• Build Log terminal output (available for 30 days)
• Build Workspace zip file of the working directory (available for 30 days)