Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we are not blocking if the operator is not able to get the Pod client #1532

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

johscheuer
Copy link
Member

Description

This is mainly a refactoring to make the getPodsToUpdate method testable.

Type of change

Please select one of the options below.

  • Bug fix (non-breaking change which fixes an issue)

Discussion

Are there any design details that you would like to discuss further?

Testing

Unit tests + e2e test.

Documentation

Follow-up

Nothing.

@johscheuer johscheuer marked this pull request as ready for review March 7, 2023 10:57
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 5841f48
  • Duration 3:37:10
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer merged commit 0d5177f into FoundationDB:main Mar 7, 2023
@johscheuer johscheuer deleted the dont-block-single-pod branch March 7, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants