Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement ProcessRole and ProcessClass #1522

Merged

Conversation

mengzhbj
Copy link
Contributor

Description

ProcessRole and ProcessClass, the two types didn't include all the existing roles and classes, this PR complements them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Discussion

No.

Testing

No.

Documentation

No, didn't need to update any doc.

Follow-up

No.

@mengzhbj mengzhbj added the bug Something isn't working label Feb 27, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9ce9579
  • Duration 1:50:52
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, once the lint check passes we can merge this one 👍

api/v1beta2/foundationdb_status.go Outdated Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: ffa7bc5
  • Duration 1:46:07
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 586425b
  • Duration 3:04:17
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@mengzhbj
Copy link
Contributor Author

mengzhbj commented Mar 1, 2023

Hi @johscheuer, the PR Builder check failed and I found following errors in logs/test_operator_upgrades.log:

 [FAIL] Operator Upgrades upgrading a cluster with a partitioned pod [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod
  /codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
  [FAIL] Operator Upgrades upgrading a cluster with a partitioned pod which eventually gets replaced [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod which eventually gets replaced
  /codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
  [FAIL] Operator Upgrades upgrading a cluster with a crash looping sidecar process [It] Upgrade from 6.3.25 to 7.1.27 with crash-looping sidecar
  /codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
  [FAIL] Operator Upgrades upgrading a cluster and one coordinator is not restarted [It] Upgrade from 6.3.25 to 7.1.27 with one coordinator not being restarted
  /codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator_upgrades/operator_upgrades_test.go:443

Can you explain a bit how to find fdb-kubernetes-tests? I've tried https://github.com/FoundationDB/fdb-kubernetes-tests but no luck. Thanks in advance.

@johscheuer johscheuer removed the request for review from ltsampros March 3, 2023 06:34
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johscheuer, the PR Builder check failed and I found following errors in logs/test_operator_upgrades.log:

[FAIL] Operator Upgrades upgrading a cluster with a partitioned pod [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster with a partitioned pod which eventually gets replaced [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod which eventually gets replaced
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster with a crash looping sidecar process [It] Upgrade from 6.3.25 to 7.1.27 with crash-looping sidecar
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster and one coordinator is not restarted [It] Upgrade from 6.3.25 to 7.1.27 with one coordinator not being restarted
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator_upgrades/operator_upgrades_test.go:443
Can you explain a bit how to find fdb-kubernetes-tests? I've tried https://github.com/FoundationDB/fdb-kubernetes-tests but no luck. Thanks in advance.

Those tests are currently not available as open source, we are working on that.

@johscheuer
Copy link
Member

Thanks!

@johscheuer johscheuer merged commit 0a38ffb into FoundationDB:main Mar 3, 2023
@mengzhbj mengzhbj deleted the complement-ProcessRole-ProcessClass branch March 3, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants