-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complement ProcessRole and ProcessClass #1522
Complement ProcessRole and ProcessClass #1522
Conversation
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, once the lint check passes we can merge this one 👍
Co-authored-by: Johannes Scheuermann <[email protected]>
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Hi @johscheuer, the PR Builder check failed and I found following errors in logs/test_operator_upgrades.log:
Can you explain a bit how to find fdb-kubernetes-tests? I've tried https://github.com/FoundationDB/fdb-kubernetes-tests but no luck. Thanks in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johscheuer, the PR Builder check failed and I found following errors in logs/test_operator_upgrades.log:
[FAIL] Operator Upgrades upgrading a cluster with a partitioned pod [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster with a partitioned pod which eventually gets replaced [It] Upgrade from 6.3.25 to 7.1.27 with partitioned Pod which eventually gets replaced
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster with a crash looping sidecar process [It] Upgrade from 6.3.25 to 7.1.27 with crash-looping sidecar
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/fixtures/status.go:35
[FAIL] Operator Upgrades upgrading a cluster and one coordinator is not restarted [It] Upgrade from 6.3.25 to 7.1.27 with one coordinator not being restarted
/codebuild/output/src833382869/src/github.com/FoundationDB/fdb-kubernetes-operator/fdb-kubernetes-tests/tests/test_operator_upgrades/operator_upgrades_test.go:443
Can you explain a bit how to find fdb-kubernetes-tests? I've tried https://github.com/FoundationDB/fdb-kubernetes-tests but no luck. Thanks in advance.
Those tests are currently not available as open source, we are working on that.
Thanks! |
Description
ProcessRole and ProcessClass, the two types didn't include all the existing roles and classes, this PR complements them.
Type of change
Discussion
No.
Testing
No.
Documentation
No, didn't need to update any doc.
Follow-up
No.