Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for container name in plugin's buggify crashloop command #1515

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

09harsh
Copy link
Contributor

@09harsh 09harsh commented Feb 23, 2023

Description

Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.

Handles: #1508

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Are there any design details that you would like to discuss further?
No

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Added unit tests.

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Yes

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?
Np

@09harsh 09harsh requested a review from johscheuer February 23, 2023 13:38
api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop.go Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop_test.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop_test.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop_test.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop_test.go Outdated Show resolved Hide resolved
kubectl-fdb/cmd/buggify_crash_loop_test.go Outdated Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: c629c8dcc9bfdd9e9f95531552338b21405901e9
  • Duration 4:09:47
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 1ef89e4ae0aabf751626cb439a9b72c62717c703
  • Duration 4:09:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: c5acc79c8bbe6c6dffbd051e2b90143d3ba44ac8
  • Duration 4:09:43
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@09harsh 09harsh requested a review from johscheuer March 1, 2023 17:47
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b95297931d614ebcaec193137fd353c4467679f2
  • Duration 4:09:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@09harsh 09harsh closed this Mar 8, 2023
@09harsh 09harsh reopened this Mar 8, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: b95297931d614ebcaec193137fd353c4467679f2
  • Duration 4:09:54
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@09harsh 09harsh force-pushed the pluginCrashLoopContainerName branch from b952979 to 8a05e17 Compare March 17, 2023 11:57
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 8a05e17
  • Duration 1:58:12
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johscheuer johscheuer merged commit b6a98a6 into FoundationDB:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants