Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change crashLoop setup to allow to select container #1472

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Change crashLoop setup to allow to select container #1472

merged 1 commit into from
Jan 25, 2023

Conversation

vishesh
Copy link
Contributor

@vishesh vishesh commented Jan 13, 2023 •
edited
Loading

Fixes: #1438

@vishesh
Copy link
Contributor Author

vishesh commented Jan 13, 2023 •
edited
Loading

@johscheuer : Not sure what It happening, but I'm getting this error for build. Seems like there is a codegen to convert Go types to whatever kube yaml or whatever it understands., and it doesn't know how to convert this particular type? Which doesn't make sense as map is made of primitive values (string) here, it's just nested. Figuring out a way around this.

/root/go/bin/controller-gen "crd:maxDescLen=0,crdVersions=v1,generateEmbeddedObjectMeta=true" rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/root/src/fdb-kubernetes-operator/api/v1beta1/foundationdbcluster_types.go:1994:31: not a supported map value type: *ast.ParenExpr
/root/src/fdb-kubernetes-operator/api/v1beta2/foundationdbcluster_types.go:1691:31: not a supported map value type: *ast.ParenExpr
/root/src/fdb-kubernetes-operator/api/v1beta2/foundationdbcluster_types.go:1687:2: encountered struct field "NonTLS" without JSON tag in type "RequiredAddressSet"
Error: not all generators ran successfully
run `controller-gen crd:maxDescLen=0,crdVersions=v1,generateEmbeddedObjectMeta=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -w` to see all available markers, or `controller-gen crd:maxDescLen=0,crdVersions=v1,generateEmbeddedObjectMeta=true rbac:roleName=manager-role webhook paths=./... output:crd:artifacts:config=config/crd/bases -h` for usage

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: d6b57a0a176c7632d2f7256197ba5506d7fb84bd
  • Duration 1:26:08
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

johscheuer
johscheuer reviewed Jan 13, 2023
View reviewed changes
api/v1beta1/foundationdbcluster_types.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types.go Outdated Show resolved Hide resolved
@vishesh vishesh force-pushed the rdar-103033891 branch 3 times, most recently from f32df10 to f660a8e Compare January 19, 2023 21:29
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: f32df10ffc00f620fb2619fb88b04eb157d49bca
  • Duration 0:06:05
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version f32df10ffc00f620fb2619fb88b04eb157d49bca
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: f660a8e1cbddbb7d73ed2a0d72d6fe49b6be9f53
  • Duration 1:28:58
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a3efeafa741eb42a612d044a8daedebb38c90b04
  • Duration 3:46:31
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@vishesh vishesh force-pushed the rdar-103033891 branch 2 times, most recently from 9460a64 to 0b88052 Compare January 20, 2023 08:11
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0b88052c2358f9ea62a394aa778e3196377d3eb6
  • Duration 1:27:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 9460a640db2b839ae25ebcd0addf72da8b4a71b8
  • Duration 3:36:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

johscheuer
johscheuer reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the NormalizeClusterSpec method to convert the existing CrashLoop into the new format. That makes the internal handling easier and we only have to work with the CrashLoopContainers. You can put the conversion method here: https://github.com/FoundationDB/fdb-kubernetes-operator/blob/main/internal/deprecations.go#L59 (between the custom parameter validation and the if statement).

api/v1beta2/foundationdbcluster_types.go Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types.go Show resolved Hide resolved
api/v1beta2/foundationdbcluster_types_test.go Outdated Show resolved Hide resolved
docs/cluster_spec.md Outdated Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: c14df68912277a529a495cc8e33ed1b3f3b4af7f
  • Duration 1:51:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@vishesh vishesh force-pushed the rdar-103033891 branch 3 times, most recently from 4e4301c to e5f361b Compare January 21, 2023 01:41
@vishesh
Copy link
Contributor Author

vishesh commented Jan 21, 2023

Are we using existing CrashLoop somewhere? I couldn't find any use of CrashLoop in our tests repository. If we are not using it, don't think we need to support conversions, and can just remove CrashLoop at some point.

@vishesh vishesh changed the title [WIP] Change crashLoop setup to allow to select container Change crashLoop setup to allow to select container Jan 21, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 4e4301c6cf222bf3d5a675e654b4a8a2e9fd257e
  • Duration 0:06:09
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 4e4301c6cf222bf3d5a675e654b4a8a2e9fd257e
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@vishesh vishesh marked this pull request as ready for review January 21, 2023 01:46
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 0450cfe953572d44f81c790f05f3f4bd89073def
  • Duration 1:34:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e5f361b7bef6adad00fe45b7128ac640c65cff1f
  • Duration 2:42:05
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@vishesh vishesh mentioned this pull request Jan 23, 2023
Merged
@vishesh vishesh force-pushed the rdar-103033891 branch 2 times, most recently from 81afd82 to bf7c337 Compare January 23, 2023 23:46
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 81afd826d5727467943e04b1075c443dab7b2478
  • Duration 4:06:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: bf7c337f3492c06362e0aeb82c5dc949e42fd293
  • Duration 4:06:05
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

johscheuer
johscheuer requested changes Jan 24, 2023
View reviewed changes
api/v1beta2/foundationdbcluster_types.go Show resolved Hide resolved
internal/pod_models.go Outdated Show resolved Hide resolved
internal/pod_models_test.go Outdated Show resolved Hide resolved
internal/pod_models_test.go Outdated Show resolved Hide resolved
internal/pod_models_test.go Outdated Show resolved Hide resolved
internal/replacements/replace_failed_process_groups.go Outdated Show resolved Hide resolved
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: f8e789c
  • Duration 4:06:09
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer closed this Jan 25, 2023
@johscheuer johscheuer reopened this Jan 25, 2023
johscheuer
johscheuer approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is unrelated to the changes and we have an issue to investigate that failure.I'm fine with merging this PR as it is and continue working on the feature in #1484.

Thanks!

internal/replacements/replace_failed_process_groups.go Show resolved Hide resolved
@johscheuer johscheuer merged commit 4fa1bda into FoundationDB:main Jan 25, 2023
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: f8e789c
  • Duration 4:06:16
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johscheuer johscheuer johscheuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change crashLoop setup to allow to select container
3 participants
@vishesh @foundationdb-ci @johscheuer