Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better logging for fdb client calls #1317

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

johscheuer
Copy link
Member

Description

Adds a logging call when we read a value from FDB with the fdb client and add an additional log when the call ended to see how long the call took.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Testing

Locally.

Documentation

Follow-up

@johscheuer johscheuer requested a review from brownleej August 5, 2022 12:56
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 23e7522
  • Duration 1:27:58
  • Result: ❌ FAILED
  • Error: Error while executing command: make -C tests -kj prOperator. Reason: exit status 2
  • Build Logs (available for 30 days)

Copy link
Member

@brownleej brownleej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johscheuer johscheuer merged commit 2db7d4a into FoundationDB:main Aug 16, 2022
@johscheuer johscheuer deleted the improve-client-logging branch August 16, 2022 07:00
JoshuaMcManus pushed a commit to JoshuaMcManus/fdb-kubernetes-operator that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants