Skip to content

Commit

Permalink
- Address a review comment (remove an upgrade test)
Browse files Browse the repository at this point in the history
  • Loading branch information
sbodagala committed May 2, 2023
1 parent 2b65a07 commit e8cd310
Showing 1 changed file with 0 additions and 64 deletions.
64 changes: 0 additions & 64 deletions e2e/test_operator_upgrades/operator_upgrades_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -403,70 +403,6 @@ var _ = Describe("Operator Upgrades", Label("e2e"), func() {
fixtures.GenerateUpgradeTableEntries(testOptions),
)

DescribeTable(
"upgrading a cluster where a storage and multiple stateless processes get restarted during the staging phase",
func(beforeVersion string, targetVersion string) {
isAtLeast := factory.OperatorIsAtLeast(
"v1.14.0",
)

if !isAtLeast {
Skip("operator doesn't support feature for test case")
}

if fixtures.VersionsAreProtocolCompatible(beforeVersion, targetVersion) {
Skip("this test case only affects version incompatible upgrades")
}

clusterSetup(beforeVersion, true)

// Select half of the stateless processes.
statelessPods := fdbCluster.GetStatelessPods()
Expect(statelessPods.Items).NotTo(BeEmpty())
selectedPods := fixtures.RandomPickPod(
statelessPods.Items,
len(statelessPods.Items)/2,
)

// Select a random storage process, and append it to "selectedPods".
storagePods := fdbCluster.GetStoragePods()
Expect(storagePods.Items).NotTo(BeEmpty())
selectedPods = append(selectedPods, fixtures.RandomPickOnePod(statelessPods.Items))

// Disable the feature that the operator restarts processes. This allows us to restart the processes
// selected above once all new binaries are present.
fdbCluster.SetKillProcesses(false)

// Start the upgrade.
Expect(fdbCluster.UpgradeCluster(targetVersion, false)).NotTo(HaveOccurred())

// Wait until all process groups are in the staging phase and the new binaries are available.
Eventually(func() bool {
return fdbCluster.AllProcessGroupsHaveCondition(fdbv1beta2.IncorrectCommandLine)
}).WithTimeout(10 * time.Minute).WithPolling(2 * time.Second).Should(BeTrue())

// Restart the processes selected above to pickup the new configuration and run with the
// newer version.
for _, selectedPod := range selectedPods {
_, _, err := fdbCluster.ExecuteCmdOnPod(
selectedPod,
fdbv1beta2.MainContainerName,
"pkill fdbserver",
false,
)
Expect(err).NotTo(HaveOccurred())
}

// Allow the operator to restart processes and the upgrade should continue and finish.
fdbCluster.SetKillProcesses(true)
},

EntryDescription(
"Upgrade from %[1]s to %[2]s with a storage and multiple stateless processes restarted during the staging phase",
),
fixtures.GenerateUpgradeTableEntries(testOptions),
)

DescribeTable(
"upgrading a cluster with a crash looping sidecar process",
func(beforeVersion string, targetVersion string) {
Expand Down

0 comments on commit e8cd310

Please sign in to comment.