add experimental comment

FoundationDB · Sep 12, 2022 · 3976714 · 3976714
1 parent 4555882
commit 3976714
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/kubectl-fdb/cmd/profile_analyzer.go b/kubectl-fdb/cmd/profile_analyzer.go
@@ -86,7 +86,7 @@ func newProfileAnalyzerCmd(streams genericclioptions.IOStreams) *cobra.Command {
 			return runProfileAnalyzer(kubeClient, namespace, clusterName, startTime, endTime, topRequests, templateName)
 		},
 		Example: `
-# Run the profiler for cluster-1 in the default namespace for the provided state and end time.
+# This sub-command is still experimental. It still has multiple things to do before making it a stable command. Run the profiler for cluster-1 in the default namespace for the provided state and end time.
 kubectl fdb analyze-profile -c cluster-1 --start-time "01:01 20/07/2022 BST" --end-time "01:30 20/07/2022 BST" --top-requests 100 --template-name job.yaml
 `,
 	}

diff --git a/kubectl-fdb/cmd/profile_analyzer_test.go b/kubectl-fdb/cmd/profile_analyzer_test.go
@@ -44,10 +44,9 @@ var _ = Describe("profile analyser", func() {
 		var kubeClient client.Client
 
 		BeforeEach(func() {
-			var cluster *fdbv1beta2.FoundationDBCluster
 			_ = clientgoscheme.AddToScheme(scheme)
 			_ = fdbv1beta2.AddToScheme(scheme)
-			cluster = &fdbv1beta2.FoundationDBCluster{
+			cluster := &fdbv1beta2.FoundationDBCluster{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      clusterName,
 					Namespace: namespace,
@@ -84,10 +83,9 @@ var _ = Describe("profile analyser", func() {
 		var kubeClient client.Client
 
 		BeforeEach(func() {
-			var cluster *fdbv1beta2.FoundationDBCluster
 			_ = clientgoscheme.AddToScheme(scheme)
 			_ = fdbv1beta2.AddToScheme(scheme)
-			cluster = &fdbv1beta2.FoundationDBCluster{
+			cluster := &fdbv1beta2.FoundationDBCluster{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      clusterName,
 					Namespace: namespace,

diff --git a/sample-apps/fdb-profile-analyzer/Dockerfile b/sample-apps/fdb-profile-analyzer/Dockerfile
@@ -1,6 +1,7 @@
 FROM python:3.9-slim
 USER root
 
+ARG FDB_VERSION=7.1.21
 RUN apt-get update \
     && apt-get  install -y wget \
                          bind9-utils \
@@ -15,10 +16,10 @@ RUN groupadd -g 4059 foundationdb
 RUN useradd -m -d / -s /bin/bash -u 4059 -o foundationdb -g 4059
 RUN mkdir /app/
 RUN chown foundationdb:foundationdb -R /app/
-RUN pip install foundationdb==7.1.21
+RUN pip install foundationdb==${FDB_VERSION}
 RUN pip install dateparser==1.1.1
-RUN wget https://github.com/apple/foundationdb/releases/download/7.1.19/foundationdb-clients_7.1.19-1_amd64.deb && \
-    dpkg -i foundationdb-clients_7.1.19-1_amd64.deb
+RUN wget https://github.com/apple/foundationdb/releases/download/${FDB_VERSION}/foundationdb-clients_${FDB_VERSION}-1_amd64.deb && \
+    dpkg -i foundationdb-clients_${FDB_VERSION}-1_amd64.deb
 WORKDIR /app/
 USER foundationdb
-RUN wget https://raw.githubusercontent.com/apple/foundationdb/7.1.21/contrib/transaction_profiling_analyzer/transaction_profiling_analyzer.py
+RUN wget https://raw.githubusercontent.com/apple/foundationdb/${FDB_VERSION}/contrib/transaction_profiling_analyzer/transaction_profiling_analyzer.py
diff --git a/sample-apps/fdb-profile-analyzer/sample_template.yaml b/sample-apps/fdb-profile-analyzer/sample_template.yaml
@@ -15,8 +15,6 @@ spec:
         - args:
             - --copy-library
             - "6.2"
-            - --copy-binary
-            - fdbcli
             - --output-dir
             - /var/output-files/6.2.30
             - --init-mode
@@ -28,8 +26,6 @@ spec:
         - args:
             - --copy-library
             - "6.3"
-            - --copy-binary
-            - fdbcli
             - --output-dir
             - /var/output-files/6.3.24
             - --init-mode
@@ -41,8 +37,6 @@ spec:
         - args:
             - --copy-library
             - "7.1"
-            - --copy-binary
-            - fdbcli
             - --output-dir
             - /var/output-files/7.1.19
             - --init-mode