-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep "Hang Up" button on dialer #9
Comments
Even on large screens it works like this. Dialpad never had it implemented. Also, I don't think the toggle in options is needed, I'd just always display the hang up button under the dialpad. |
@Aga-C I agree. The current dialpad UI isn't large enough to justify a dynamic behavior (unless it becomes too large for small screens with the static end call button)
Not related to the dialpad but the overall button sizes were reduced to avoid overlapping elements on small screens.
@minosimo Absolutely, PRs are welcome as long as they properly solve a problem and are not low quality. I suggest you wait for the initial release to avoid potential conflicts. |
Don't hide hang up button when showing dialpad (#9)
Checklist
I opened this same issue in the original repo before reading about the sale.
I recently installed Dialer on my grandmother's phone. Her one frustration occurs when trying to hang up a call after using the dial pad. She checks her voicemail by calling a number, and needs to open the dial pad to interact with the voicemail. When done, she looks on screen but does not see the hang up button, and does not know where to find it, which means she goes back to the home screen and gets stuck with a call running in the background.
I compared to the stock Graphene OS dialer, which maintains the hang up button in the dialpad. I believe the Google dialer must do this as well.
I am guessing that Simple Dialer hides the call button to keep compatibility with smaller screens, and to make it easier to dial with one hand. That said, would there be interest in a PR that addresses this?
I see two potential methods, either an adaptive behavior where the dialpad hides or shows the hang up button depending on screen size, or a toggle in options for "Show hang-up button on dialpad". If a PR would be welcome, which would be better?
The text was updated successfully, but these errors were encountered: