Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "Hang Up" button on dialer #9

Closed
5 tasks done
minosimo opened this issue Jan 7, 2024 · 2 comments · Fixed by #44
Closed
5 tasks done

Keep "Hang Up" button on dialer #9

minosimo opened this issue Jan 7, 2024 · 2 comments · Fixed by #44
Labels
enhancement New feature or request

Comments

@minosimo
Copy link

minosimo commented Jan 7, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

I opened this same issue in the original repo before reading about the sale.

I recently installed Dialer on my grandmother's phone. Her one frustration occurs when trying to hang up a call after using the dial pad. She checks her voicemail by calling a number, and needs to open the dial pad to interact with the voicemail. When done, she looks on screen but does not see the hang up button, and does not know where to find it, which means she goes back to the home screen and gets stuck with a call running in the background.

I compared to the stock Graphene OS dialer, which maintains the hang up button in the dialpad. I believe the Google dialer must do this as well.

I am guessing that Simple Dialer hides the call button to keep compatibility with smaller screens, and to make it easier to dial with one hand. That said, would there be interest in a PR that addresses this?

I see two potential methods, either an adaptive behavior where the dialpad hides or shows the hang up button depending on screen size, or a toggle in options for "Show hang-up button on dialpad". If a PR would be welcome, which would be better?

@minosimo minosimo added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 7, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 7, 2024
@Aga-C
Copy link
Member

Aga-C commented Jan 7, 2024

 I am guessing that Simple Dialer hides the call button to keep compatibility with smaller screens, and to make it easier to dial with one hand. 

Even on large screens it works like this. Dialpad never had it implemented.

Also, I don't think the toggle in options is needed, I'd just always display the hang up button under the dialpad.

@naveensingh
Copy link
Member

naveensingh commented Jan 7, 2024

I don't think the toggle in options is needed, I'd just always display the hang up button under the dialpad

@Aga-C I agree. The current dialpad UI isn't large enough to justify a dynamic behavior (unless it becomes too large for small screens with the static end call button)

I am guessing that Simple Dialer hides the call button to keep compatibility with smaller screens

Not related to the dialpad but the overall button sizes were reduced to avoid overlapping elements on small screens.

If a PR would be welcome, which would be better?

@minosimo Absolutely, PRs are welcome as long as they properly solve a problem and are not low quality. I suggest you wait for the initial release to avoid potential conflicts.

Aga-C added a commit to Aga-C/Phone that referenced this issue Jan 20, 2024
naveensingh added a commit that referenced this issue Mar 17, 2024
Don't hide hang up button when showing dialpad (#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants