Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limit to the message box size (#55) #58

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Jan 28, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

Added limit of 5 lines to the message box size. It's the same limit as in OnePlus stock SMS app and Signal.

Before/After Screenshots/Screen Record

  • Before:
qemu-system-x86_64_sOjUfihEBs.mp4
  • After:
qemu-system-x86_64_TwMtWHisjZ.mp4

Fixes the following issue(s)

Acknowledgement

@debie-A320FL
Copy link

I mostly dislike the limit of 5. Could it be possible to increase this limit (to 15 ?) or be able to set it in settings (in order to fit phone sizes and users preferences) ? A limit of 5 is not quite useful with very long message and a large message box while writing a long message is part of the reasons why I use the app.

@naveensingh
Copy link
Member

I agree, let's bump it to 8 or 10 lines. We'll consider a preference if it is requested by many users.

@naveensingh
Copy link
Member

Great, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To big message box -> could not view other messages
3 participants