Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Format phone numbers, when saving them #15

Closed
5 tasks done
inson1 opened this issue Jan 4, 2024 · 10 comments · Fixed by #72
Closed
5 tasks done

[Enhancement] Format phone numbers, when saving them #15

inson1 opened this issue Jan 4, 2024 · 10 comments · Fixed by #72
Labels
enhancement New feature or request

Comments

@inson1
Copy link

inson1 commented Jan 4, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
Phone numbers looks bad and ugly. Currently, the phone numbers are just unformated strings of numbers, for example 555555555555.

Describe the solution you'd like
title
They should instead look like (555) 555-5555-555, +1-212-555-0101, 555 555 5555 555 or +491631737743 etc.
Its going to vary from country to country. That should be the default and then you could change it in settings to another format.

@inson1 inson1 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 4, 2024
@inson1 inson1 changed the title [Feature Request] Format the phone numbers, when saving them [Feature Request] Format phone numbers, when saving them Jan 4, 2024
@inson1
Copy link
Author

inson1 commented Jan 4, 2024

SimpleMobileTools/Simple-Contacts#1012

@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 4, 2024
@inson1 inson1 changed the title [Feature Request] Format phone numbers, when saving them [Enhancement] Format phone numbers, when saving them Jan 4, 2024
@Rexadev
Copy link

Rexadev commented Jan 25, 2024

Conditions

  1. If 1 number appear 3 times in a row group it
  2. If 1 number appear 2 times in a row group it
  3. But when grouping 2 numbers like in condition 2 if a lone no. if on it's left or right take it into the group
  4. There should be min 3 groups and max 4

@inson1
Copy link
Author

inson1 commented Jan 25, 2024

@Rexadev may you show some examples? I dont get it tbh, I mean mainly 2 and 3

@Netpilgrim
Copy link

Because there are many different national standards and personal preferences with regard to grouping, I strongly suggest that the default should always be the string as entered or imported.
The only sensible format for any kind of normalization would be the international ITU format without any grouping, e.g. +491631737743 (also the safest choice for copy-and-pasting).

@inson1
Copy link
Author

inson1 commented Jan 29, 2024

@Netpilgrim cant it be done based on language maybe? and then on preference?

@theoUniv
Copy link
Contributor

Hi,

Me and @Aychoumane are computer science students at the Paris 8 University.

In the context of free-software development class, we have to contribute to a project of our choice, so we would like to work on this issue.

We were thinking of using the android.PhoneNumberUtils library, would it be ok ?

Thanks.

@inson1
Copy link
Author

inson1 commented Jan 30, 2024

@theoUniv its android.telephony.PhoneNumberUtils, right? If yes this project already uses it, so if end result is good then I dont see any problem :)
https://github.com/search?q=repo%3AFossifyOrg%2FContacts+PhoneNumberUtils&type=code

@theoUniv
Copy link
Contributor

theoUniv commented Feb 5, 2024

remote: Permission to FossifyOrg/Contacts.git denied to theoUniv.
fatal: unable to access 'https://github.com/FossifyOrg/Contacts.git/': The requested URL returned error: 403

While trying to push our branch on the git, to make a merge request. We got this error.

Any requirement to contribute by coding ?

@Aga-C
Copy link
Member

Aga-C commented Feb 5, 2024

@theoUniv When working on open-source projects, you have to work on your own fork and after finishing work, create PR for merging the fork with upstream. Read how it works, e.g. here: https://www.freecodecamp.org/news/how-to-fork-a-github-repository/.

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Feb 20, 2024

#15 (comment)

@inson1, I would like them formatted as https://datatracker.ietf.org/doc/html/rfc3966#section-3 specifies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants