Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for 24 and 12 hour time formats (#52) #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better support for 24 and 12 hour time formats (#52) #62

wants to merge 1 commit into from

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Apr 6, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added zero padding for hour in 24-hour digital clock (both app and widget), because it's a standard formatting.
  • Added AM/PM indicator in 12-hour digital clock widget.
  • Added switch between 12 and 24-hour time formats.
    • Original issue was mentioning this kind of switch, and since it's already in Calendar, it could be also done here.
    • By default, it uses system time format.
    • It works for all clocks in the app and for digital clock widget.

Before/After Screenshots/Screen Record

qemu-system-x86_64_VDfOYWNe9E.mp4

Fixes the following issue(s)

Acknowledgement

@frobby
Copy link

frobby commented Sep 1, 2024 •
edited by fossifybot
Loading

May I suggest adding a setting for a custom date/time format?
Using format codes such as these
Screenshot2
eg: I would like to change the date format to: "Mon 02 Sep" instead of "Mon, 2 Sept"

@Joshix-1
Copy link

The switch between the formats should imho have 3 states: system default, 12h format and 24h format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When displaying 24 hour time, digits should be padded
3 participants
@Aga-C @frobby @Joshix-1