Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When displaying 24 hour time, digits should be padded #52

Open
6 of 7 tasks
mintsoft opened this issue Apr 2, 2024 · 2 comments · May be fixed by #62
Open
6 of 7 tasks

When displaying 24 hour time, digits should be padded #52

mintsoft opened this issue Apr 2, 2024 · 2 comments · May be fixed by #62
Labels
enhancement New feature or request

Comments

@mintsoft
Copy link

mintsoft commented Apr 2, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

The default time format (9:42:01) looks odd to my British eyes without the leading zero. There doesnt seem to be anywhere to customize this or turn on 24hr clock mode etc.

Why do you want this feature?

User preference and familiarity. As a 24hr time user, it is easier for me to recognize and read the time in consistent formats.

Additional information

No response

@mintsoft mintsoft added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Apr 2, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Apr 2, 2024
@Aga-C
Copy link
Member

Aga-C commented Apr 2, 2024

There should be an option to switch between 12 and 24 hour system, but there shouldn't be an option for setting leading zero. We should always pad 24 hour time, and leave 12 hour as it is.

@mintsoft
Copy link
Author

mintsoft commented Apr 2, 2024

Yeah I agree with that, so I guess the bug is that 24 hour time isn't padded currently as the clock does show (for example) 14:43:50 but not 09:02:54

@mintsoft mintsoft changed the title Add customisable format When displaying 24 hour time, digits should be padded Apr 2, 2024
Aga-C added a commit to Aga-C/Clock that referenced this issue Apr 6, 2024
@Aga-C Aga-C linked a pull request Apr 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants