Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added opening daily view from weekly view (#344) #348

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Added opening daily view from weekly view (#344) #348

merged 4 commits into from
Nov 14, 2024

Conversation

Aga-C
Copy link
Member

@Aga-C Aga-C commented Oct 13, 2024

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • Added opening daily view from weekly view.
  • Code is a bit different than opening from monthly, because we need to show FAB that's not present in weekly. I've based it on opening monthly from yearly.
  • Also, I've fixed one condition in MainActivity to hide FAB in weekly. It was wrong, but because we didn't have jumping between views in weekly, it didn't show up.

Before/After Screenshots/Screen Record

qemu-system-x86_64_9Heqbfsp39.mp4

Fixes the following issue(s)

Acknowledgement

@naveensingh
Copy link
Member

Looks good, thanks!

@naveensingh naveensingh merged commit fbed60c into FossifyOrg:master Nov 14, 2024
2 of 4 checks passed
@Aga-C Aga-C deleted the open-day-from-weekly branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tap jump to day view
2 participants
@Aga-C @naveensingh