Skip to content

Commit

Permalink
site: leaderboard: Sort NULLs last
Browse files Browse the repository at this point in the history
The inner order sorts NULLs last, so the outer one should too.

Fixes: 4edf9ff ("site: leaderboard: Fix intra-page sorting")
Signed-off-by: Sean Anderson <[email protected]>
  • Loading branch information
Forty-Bot committed Apr 17, 2024
1 parent 2245249 commit 79f9e4c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion trends/site/leaderboards.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def overview():
) AS leaderboard
LEFT JOIN player USING (playerid)
LEFT JOIN name USING (nameid)
ORDER BY {order_clause};""",
ORDER BY {order_clause} NULLS LAST;""",
{ **filters, 'grouping': grouping, 'limit': limit, 'offset': offset })
resp = flask.make_response(flask.render_template("leaderboards/overview.html",
leaderboard=leaderboard.fetchall()))
Expand Down

0 comments on commit 79f9e4c

Please sign in to comment.