Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: override for synthetic functions #68

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

ForteScarlet
Copy link
Owner

resolve #67

In the previous K2 mode, the override of a synthesized function always came directly from the original function.

Now, if the original function is override, a judgment is made based on all of its parent functions as to whether the synthetic function should also add override.

In the case of JvmBlocking, it is assumed that the synthetic function should be override if there are any parent functions that also contain this annotation, and the final function name and asProperty are also the same.

Although some other optimizations have been made in addition to judging directly from the original function, they are less recommended ways of using it and may be flawed, so I won't express them.

nothing One complaint I have to make is that implementing inheritance relationships between judgment functions in the plugin is quite a bit more complicated than I thought it would be. 😢

@ForteScarlet ForteScarlet added the bug Something isn't working label Oct 5, 2024
@ForteScarlet ForteScarlet merged commit e7e6607 into dev Oct 5, 2024
1 check passed
@ForteScarlet ForteScarlet deleted the optimize-#67 branch October 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when overriding an Interface
1 participant