Introduced FaIconLibrary managed by Angular
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To provide a better name and in preparation to introduce more configuration options.
Usage:
```
export class AppModule {
constructor(library: FaIconLibrary) {
library.addIcons(faCoffee);
}
}
```
Using DI instead of the syntax discussed in the issue
(`FontAwesomeModule.withIcons(faUser)`) as this is more flexible and
future proof given that future version of Angular renderer (Ivy) is
going make usage of modules optional.
---
Deprecated using library from `@fortawesome/fontawesome-svg-core` in
favor of the new class. Previous library was problematic in several
ways:
- global variable, which was shared by all code on the page
- more complicated for consumers as they need to know about existence of
`fontawesome-svg-core` and that it is used by `angular-fontawesome`
- library from `fontawesome-svg-core` implementation was pretty complex
This deprecation is the first step on the way to make
`fontawesome-svg-core` an implementation detail of
`angular-fontawesome`, which consumers don't need to be aware about.
Fixes FortAwesome#3
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
Using DI instead of the syntax discussed in the issue
(
FontAwesomeModule.withIcons(faUser)) as this is more flexible andfuture proof given that future version of Angular renderer (Ivy) is
going make usage of modules optional.
Deprecated using library from
@fortawesome/fontawesome-svg-coreinfavor of the new class. Previous library was problematic in several
ways:
fontawesome-svg-coreand that it is used byangular-fontawesomefontawesome-svg-coreimplementation was pretty complexThis deprecation is the first step on the way to make
fontawesome-svg-corean implementation detail ofangular-fontawesome, which consumers don't need to be aware about.Fixes #3