This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Minor version pin for core victory libraries #676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #674 reports that Victory core 35.11.0 breaks Victory Native. I suspect this is due to some of the class-to-function component conversions in the core (released in 35.11.0) which are not respected in Victory Native.
One solution, short term, is for users to pin their versions via yarn's
resolutions
field. However, to avoid everyone having to do that, I'm proposing we do minor-version pinning at the library level here so this won't break for future users, and we don't have to tell people to do user-landresolutions
to get the library to work.Eventually, Victory Native's code will need to be updated to potentially move from class inheritance to function composition - but this seems like a fair short-time fix.