This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
disableContainerEvents
prop for all containers. This prop will allow users to turn off all panResponder events for any VictoryContainer component. While this prop istrue
, evented containers likeVictoryVoronoiContainer
to stop registering any events.This is will help users who are
Obviously this solution has some trade offs, since it turns off all container events. I recognize that it isn't a fix for some of the issues I mentioned above, but it should give folks more options.