Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

add option to disable panResponder #378

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Sep 13, 2018

Adds disableContainerEvents prop for all containers. This prop will allow users to turn off all panResponder events for any VictoryContainer component. While this prop is true, evented containers like VictoryVoronoiContainer to stop registering any events.

This is will help users who are

  1. trying to use Victory with a different gesture library
  2. having issues with press events, especially in android: https://github.com/FormidableLabs/victory-native/issues/96
  3. having issues with scrolling: https://github.com/FormidableLabs/victory-native/issues/375

Obviously this solution has some trade offs, since it turns off all container events. I recognize that it isn't a fix for some of the issues I mentioned above, but it should give folks more options.

@boygirl boygirl merged commit 8065814 into master Sep 13, 2018
@boygirl boygirl deleted the improvement/option-to-disable-panResponder branch September 13, 2018 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant