Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

add warning to postinstall #69

Merged
merged 3 commits into from
Jan 8, 2016
Merged

add warning to postinstall #69

merged 3 commits into from
Jan 8, 2016

Conversation

knowbody
Copy link
Contributor

@knowbody knowbody commented Jan 4, 2016

knowbody and others added 3 commits January 4, 2016 15:45
bump archetype version
...otherwise we always exit 1, even when successful.
@coopy
Copy link
Contributor

coopy commented Jan 7, 2016

@knowbody I needed to add ( ... ) around the echo && exit 1 condition, otherwise exit 1 always happens.

The weird c++ error is a separate issue that has been around for a while (try expanding the $ npm install part of the output in https://travis-ci.org/FormidableLabs/victory-axis/jobs/98165885, for example).

@coopy
Copy link
Contributor

coopy commented Jan 7, 2016

@boygirl
Copy link

boygirl commented Jan 7, 2016

yay! thanks @coopy

@ryan-roemer
Copy link
Member

@knowbody @coopy -- Has anyone validated this on Windows? (with the new parens)

@knowbody
Copy link
Contributor Author

knowbody commented Jan 7, 2016

@ryan-roemer I didn't, no windows machine. Would be great to add appveyor ASAP

@ryan-roemer
Copy link
Member

@knowbody -- I see ievms and iectrl in your future ;)

@knowbody
Copy link
Contributor Author

knowbody commented Jan 7, 2016

@ryan-roemer the last windows I saw, was win98 😜

but let me see the "future"

@ryan-roemer
Copy link
Member

@knowbody -- Here, I did it for you ;)

Here is a "failing" command with parens:

> cmd /C "cd lib || (echo hi && exit 1)"
The system cannot find the path specified.
hi

> echo %errorlevel%
1

Here is a success command:

> cmd /C "echo ho || (echo hi && exit 1)"
ho

> echo %errorlevel%
0

So it appears everything works on windows with the parens as we have it now.

@knowbody
Copy link
Contributor Author

knowbody commented Jan 7, 2016

Thank you @ryan-roemer, I'm checking ievms and iectrl anyway!

@coopy
Copy link
Contributor

coopy commented Jan 8, 2016

👍

coopy pushed a commit that referenced this pull request Jan 8, 2016
@coopy coopy merged commit 44ca07e into master Jan 8, 2016
@coopy coopy deleted the knowbody-patch-1 branch January 8, 2016 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants