Fix react warning #656
Merged
Fix react warning #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 60246ae We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
commented
Mar 21, 2020
kitten
approved these changes
Mar 22, 2020
| "main": "dist/urql-exchange-suspense", | ||
| "module": "dist/urql-exchange-suspense.mjs", | ||
| "main": "dist/urql-exchange-suspense.js", | ||
| "module": "dist/urql-exchange-suspense.es.js", |
There was a problem hiding this comment.
I think we’ll also want “exports” removed. I’ll do another check and maybe a subsequent PR as I’m unsure whether we need the dependency on React or whether it’s just to indicate that it’s for React 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when
executeMutationstill has to setState and theuseQuery(or related) has reset the state already this could be an issue.fixes: #655
Set of changes
isMountedchecks touseSourceanduseMutation