Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] Can't perform a React state update on an unmounted component. #655

Closed
zenios opened this issue Mar 21, 2020 · 4 comments · Fixed by #656
Closed

[react] Can't perform a React state update on an unmounted component. #655

zenios opened this issue Mar 21, 2020 · 4 comments · Fixed by #656
Labels
bug 🐛 Oh no! A bug or unintented behaviour.

Comments

@zenios
Copy link

zenios commented Mar 21, 2020

Reproduction

https://codesandbox.io/s/wizardly-wright-f42o1

This has been discussed again and fixed

#493

but i think it broke again when use-sbuscription was removed
@zenios zenios added the bug 🐛 Oh no! A bug or unintented behaviour. label Mar 21, 2020
@JoviDeCroock
Copy link
Collaborator

I'm not seeing any errors, I just clicked the button a few times.

image

@zenios
Copy link
Author

zenios commented Mar 21, 2020

Screenshot from 2020-03-21 23-43-15

@JoviDeCroock JoviDeCroock mentioned this issue Mar 21, 2020
Merged
@JoviDeCroock
Copy link
Collaborator

Got it, your sandbox was missing the {!data.todo.complete && <Button />} part, was probably lagging behind for me. Thanks!

@zenios
Copy link
Author

zenios commented Mar 21, 2020

You are on fire :)

Two issues both fixed in less than an hour. Congrats

@zenios zenios changed the title Can't perform a React state update on an unmounted component. [react] Can't perform a React state update on an unmounted component. Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Oh no! A bug or unintented behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix react warning urql-graphql/urql
2 participants
@zenios @JoviDeCroock