Presenter mode should show the next animation rather than the next slide #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverseDirection was always false when advancing from non-zero currentSlideElement
5 tasks
kale-stew
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
I was initially hesitant to introduce a second Context to track the next element, since it seems like something that should be wrapped up into the presentation already via the existing SlideContext, but I think I've come around. As a note to our future selves, we should probably look at using this NextElementContext to fix a few other oddities in the presenter mode.
Thank you for this contribution, @vlsi, and bearing with the accidental PR closure! 🚢 Merging this one now.
|
Thanks. I agree an extra context looks weird, however, I thought it should be good enough from the understanding and maintenance points of view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #914
Type of Change
Please delete options that are not relevant (including this descriptive text).
How Has This Been Tested?
Tested with
start:js, presenter view now properly shows the preview of the next animation.Checklist: (Feel free to delete this section upon completion)