Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALT-O Keyboard shortcut fix. Issue: #888 #893

Merged
merged 2 commits into from
May 11, 2020

Conversation

awareness481
Copy link
Contributor

@awareness481 awareness481 commented May 3, 2020

Description

Pull request to address the issue of keyboard shortcuts not working for Mac. I also discovered that the shortcuts weren't working for Windows as well.

Fixes #888

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The conditions for keyboard shortcuts for Windows & Mac were always falsy, unless CAPS lock was enabled. Tested locally on Windows, however please test additionally for Mac machines before merging.

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • My code follows the style guidelines of this project (I have run yarn format)
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings

@awareness481
Copy link
Contributor Author

Seems like the conditional for Mac should use .toLowerCase() instead of .toUpperCase()?

@kale-stew
Copy link
Contributor

I agree, @awareness481 - reviewing your PR now. Currently, the presenterMode tests are failing, might have something to do with that callout.

@kale-stew kale-stew added the 🐛 Bug Issues or PRs that report or fix a bug label May 11, 2020
@kale-stew
Copy link
Contributor

Aaaand you were right! Pushed up that change, we should be good to merge pending final tests. 👍 Thanks for the contribution!

@kale-stew kale-stew merged commit af4dea1 into FormidableLabs:master May 11, 2020
kale-stew pushed a commit that referenced this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Issues or PRs that report or fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview Mode seems to be broken
2 participants