Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite: add webpack mdx #689

Merged
merged 8 commits into from
Jun 12, 2019
Merged

Rewrite: add webpack mdx #689

merged 8 commits into from
Jun 12, 2019

Conversation

VirtualDOMinic
Copy link
Contributor

First attempt at adding MDX support to rewrite.

Should we add es/ and dist/ to .gitignore?

@VirtualDOMinic VirtualDOMinic requested a review from kiraarghy June 12, 2019 14:01
@VirtualDOMinic VirtualDOMinic self-assigned this Jun 12, 2019
First draft of working mdx support with webpack:
8f6aac4 
- `node_modules/.bin/webpack` to build dist
- `yarn start` to run on localhost
@VirtualDOMinic VirtualDOMinic force-pushed the rewrite/add-webpack-mdx branch from a74e9bc to 8f6aac4 Compare June 12, 2019 14:02
@ryan-roemer
Copy link
Member

Ignore es dist and lib. Only src should be in source

@ryan-roemer
Copy link
Member

And they’re all git ignored correctly already. I’m not sure how they could get added in a branch?

@ryan-roemer
Copy link
Member

Ah @kale-stew looks like task/rewrite branch is missing master's https://github.com/FormidableLabs/spectacle/blob/master/.gitignore Suggest we get that going in there sooner than later ;)

@VirtualDOMinic
Copy link
Contributor Author

VirtualDOMinic commented Jun 12, 2019 •
edited
Loading

And they’re all git ignored correctly already. I’m not sure how they could get added in a branch?

@ryan-roemer they're in the master .gitignore but not (yet) in the task/rewrite branch .gitignore that we're working off

@kale-stew
Copy link
Contributor

My bad 🙂 Thank you for adding those

kale-stew
kale-stew approved these changes Jun 12, 2019
View reviewed changes
test.mdx Show resolved Hide resolved
ryan-roemer
ryan-roemer reviewed Jun 12, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
kale-stew
kale-stew reviewed Jun 12, 2019
View reviewed changes
dist/index.html Outdated Show resolved Hide resolved
@ryan-roemer
Copy link
Member

Thanks for ignore file @VirtualDOMinic ! i think the dist/** files still need to get manually removed too...

@VirtualDOMinic
Copy link
Contributor Author

@ryan-roemer are you okay with us merging this in its current state? 😄

@VirtualDOMinic VirtualDOMinic changed the title WIP: Rewrite/add webpack mdx Rewrite/add webpack mdx Jun 12, 2019
@VirtualDOMinic VirtualDOMinic changed the title Rewrite/add webpack mdx Rewrite: add webpack mdx Jun 12, 2019
ryan-roemer
ryan-roemer approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work!

@VirtualDOMinic VirtualDOMinic merged commit a99411a into task/rewrite Jun 12, 2019
@VirtualDOMinic VirtualDOMinic deleted the rewrite/add-webpack-mdx branch June 12, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kale-stew kale-stew kale-stew approved these changes

@ryan-roemer ryan-roemer ryan-roemer approved these changes

@kiraarghy kiraarghy Awaiting requested review from kiraarghy

Assignees

@VirtualDOMinic VirtualDOMinic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VirtualDOMinic @ryan-roemer @kale-stew