Skip to content

Commit

Permalink
Revert replaceing 'compile' with 'implementation' in android/build.gr…
Browse files Browse the repository at this point in the history
…adle (#249)

* Revert "Replace 'compile' with 'implementation' (#242)"

This reverts commit 727945d.

* Add readme comment on patch package
  • Loading branch information
kadikraman authored Feb 18, 2019
1 parent 96ddd4c commit 1fd30d1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ class AppDelegate: UIApplicationDelegate, RNAppAuthAuthorizationFlowManager {

### Android Setup

**Note:** for RN >= 0.57, you will get a warning about compile being obsolete. To get rid of this warning, use [patch-package](https://github.com/ds300/patch-package) to replace compile with implementation [as in this PR](https://github.com/FormidableLabs/react-native-app-auth/pull/242) - we're not deploying this right now, because it would break the build for RN < 57.

To setup the Android project, you need to perform two steps:

1. [Install Android support libraries](#install-android-support-libraries)
Expand Down
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ repositories {
}

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation "net.openid:appauth:0.7.1"
compile 'com.facebook.react:react-native:+'
compile "net.openid:appauth:0.7.1"
}

0 comments on commit 1fd30d1

Please sign in to comment.