Migrate project source to TypeScript #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carloskelly13
changed the title
carloskelly13
force-pushed
the
task/convert-source-ts
branch
from
6decbd5 to
a17d681
Compare
carloskelly13
force-pushed
the
task/convert-source-ts
branch
from
8f09785 to
b3c8d00
Compare
gksander
reviewed
Mar 29, 2023
Comment on lines
5
to
+8
| import { terser } from "rollup-plugin-terser"; | ||
| import filesize from "rollup-plugin-filesize"; | ||
| import { visualizer } from "rollup-plugin-visualizer"; | ||
| import typescript from "@rollup/plugin-typescript"; |
There was a problem hiding this comment.
No need to change this now, but in the future we might look into swapping rollup out for Vite (which uses rollup under the hood), just because the plugin/config is a bit less verbose. Maybe something for "future us".
|
LOL okay, makes total sense. I wasn't paying close enough attention. |
|
@gksander Actually you helped me uncover a bug, it wasn't passing the correct value for noInline in the story—it just looked correct because of default params and how it saves transient stage in local storage. Thank you for calling that out. Pushed a fix for that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to verify:
yarn build