Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random page story to prevent chromatic problems #1059

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Apr 8, 2024

Remove the story in Storybook that set the page to a random index. When this runs in Chromatic, it causes the Chromatic test to fail because its a random number each time. This sets a specific number to avoid that problem while still testing the required functionality.

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 4184caf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuka-carousel-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 9:26pm

@carbonrobot carbonrobot merged commit fb4759b into main Apr 8, 2024
7 checks passed
@carbonrobot carbonrobot deleted the story/remove-random branch April 8, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants