Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add webpack5 support (part 1) #155

Merged
merged 4 commits into from
Dec 17, 2020
Merged

Chore: Add webpack5 support (part 1) #155

merged 4 commits into from
Dec 17, 2020

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Dec 16, 2020

  • Update fixtures to support webpack5 and use dummy webpack/webpack-cli root packages approach from webpack-stats-plugin
  • Note: Does not actually enable webpack5 in tests for Test Fixture: webpack5 #140 as there's a lot more work to do there, so we're capturing the intermediate work here.

@ryan-roemer
Copy link
Member Author

Note: Fails to build

diff --git a/package.json b/package.json
index 86ac75d..f48ba47 100644
--- a/package.json
+++ b/package.json
@@ -75,7 +75,7 @@
     "builder": "^5.0.0",
     "chai": "^4.2.0",
     "codecov": "^3.7.0",
-    "css-loader": "^3.5.3",
+    "css-loader": "^5.0.1",
     "deepmerge": "^4.2.2",
     "eslint": "^7.0.0",
     "eslint-config-formidable": "^4.0.0",
@@ -83,7 +83,7 @@
     "eslint-plugin-import": "^2.20.2",
     "eslint-plugin-promise": "^4.2.1",
     "execa": "^5.0.0",
-    "expose-loader": "^0.7.5",
+    "expose-loader": "^1.0.3",
     "inspectpack-test-fixtures": "file:test/fixtures",
     "mocha": "^8.2.1",
     "mock-fs": "^4.12.0",

@ryan-roemer ryan-roemer changed the title [WIP] Chore: Add webpack5 support Chore: Add webpack5 support (part 1) Dec 17, 2020
@ryan-roemer ryan-roemer merged commit 4b8809a into master Dec 17, 2020
@ryan-roemer ryan-roemer deleted the chore/webpack5 branch December 17, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant