Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Remove loaders from file prefixes. #79

Open
1 of 4 tasks
ryan-roemer opened this issue May 25, 2018 · 0 comments
Open
1 of 4 tasks

Feature: Remove loaders from file prefixes. #79

ryan-roemer opened this issue May 25, 2018 · 0 comments
Labels
enhancement

Comments

@ryan-roemer
Copy link
Member

ryan-roemer commented May 25, 2018 •
edited
Loading

Resolve identifiers better for things like:

$ node bin/inspectpack.js -s test/fixtures/loaders/dist-development-4/stats.json -a sizes | grep "\!"
* /Users/rye/scm/fmd/inspectpack/node_modules/css-loader/index.js!/Users/rye/scm/fmd/inspectpack/test/fixtures/loaders/src/style.css
* /Users/rye/scm/fmd/inspectpack/node_modules/raw-loader/index.js!/Users/rye/scm/fmd/inspectpack/test/fixtures/loaders/src/hello.txt
@ryan-roemer ryan-roemer mentioned this issue May 31, 2018
Merged
This was referenced Dec 12, 2018
Open
Merged
ryan-roemer added a commit that referenced this issue Dec 12, 2018
@ryan-roemer
BUG: Fix inference of node_modules for loader prefixes. (#99)
59294a3 
Part of #79

- BUG: A loader in the `identifier` field would incorrectly have all modules inferred "as a `node_modules` file", even if not. Implements a naive loader stripping heuristic to correctly assess if `node_modules` or real application source.
- Optimizes internal calls to `_isNodeModules()` from 2 to 1 for better performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryan-roemer