This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
Fixed format-versions when problem bundle does not contain the versions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that it's possible the problem bundle received from webpack does not contain the `versions` data at all. This was not handled correctly in the `formatVersions` function. Fixed the function to be more robust and added unit tests for it along the way. Unit tests for an existing case was added but really not sure if it's the right format as I never seen it :) **Note** I disabled `no-use-before-define` in my unit test as I found it makes tests much more readable. Don't hesitate to disapprove and I'll revert the change.
This was referenced Jan 17, 2018
mattcubitt
suggested changes
Feb 1, 2018
| }); | ||
| }); | ||
|
|
||
| const Problem = { |
There was a problem hiding this comment.
Hi @maoueh I would prefer you re-enabled the rule and moved the declarations to the top. I actually find this more readable and consistent with the rest of the code base. The fix looks good to me so will merge when you've done this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that it's possible the problem bundle received from webpack does
not contain the
versionsdata at all. This was not handled correctly inthe
formatVersionsfunction.Fixed the function to be more robust and added unit tests for it along the
way. Unit tests for an existing case was added but really not sure if it's
the right format as I never seen it :)
Note I disabled
no-use-before-definein my unit test as I found itmakes tests much more readable. Don't hesitate to disapprove and I'll
revert the change.