Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When printing from slicer direct to OctoPrint (via slicer plugin) offer option to print AW's output #39

Closed
TodWulff opened this issue Oct 23, 2020 · 4 comments
Labels
Enhancement Implemented This enhancement has been implemented and committed (first to devel).

Comments

@TodWulff
Copy link

When printing from the slicer direct to OctoPrint, via a slicer plugin, the AW plugin does its thing, but the print is the original gcode sent by the slicer. Can AW hook a callback to offer the user to print either the original .gcode file, or the .aw.gcode that is generated by Arc Welder?

@girrrrrrr2
Copy link

Or what about something like where if it detects a line of code in the welding, like "Print_After_Weld" in the beginning of the file (could be done automatically via start Gcode) and its a new file, it welds and automatically tries to start the print

Idk just throwing my idea out here

@FormerLurker
Copy link
Owner

@TodWulff, I've been discussing this with several people, and a hook may indeed be the best way to proceed. I've also considered adding a 'Print after welding' option to Arc Welder, though that also presents some problems. I'll be working on this.

@girrrrrrr2, it is very tricky to intercept a gcode and stop the print before anything is actually sent to the printer. Octolapse had to deal with this, and the solution is.. very ugly. At some point I may create a feature request for OctoPrint (or maybe a PR) that adds a 'before-print-start' synchronous callback that happens before any gcodes are queued.

@FormerLurker FormerLurker added the Enhancement New feature or request label Oct 25, 2020
@girrrrrrr2
Copy link

I was thinking more of a it being uploaded but not being auto started. And then when you see the line in the code, it starts the print right away, or if its printing its ignored... something like that

@FormerLurker FormerLurker added Enhancement Implemented This enhancement has been implemented and committed (first to devel). and removed Enhancement New feature or request labels Oct 28, 2020
@FormerLurker
Copy link
Owner

Hey @TodWulff and @girrrrrrr2, I've added a feature that may work for this that doesn't require modifications to slicer plugins. If you want to test it, you can install from this url within the plugin manager (get more->From Url...): https://github.com/FormerLurker/ArcWelderPlugin/archive/1.0.1.rc1.dev1.zip. Please read the release notes here. You can comment in this thread and if there are problems I may ask you to create a new issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Implemented This enhancement has been implemented and committed (first to devel).
Projects
None yet
Development

No branches or pull requests

3 participants