Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checkbox accessibility #195

Merged
merged 3 commits into from
Dec 23, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: checkbox accessibility
phoebus-84 committed Dec 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit c7b262e51b3287f114c95aab4ab8e87edb043aff
1 change: 1 addition & 0 deletions src/components/activity-card/readme.md
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@
| ------------- | ------------- | ----------- | --------- | ----------- |
| `date` | `date` | | `string` | `undefined` |
| `description` | `description` | | `string` | `undefined` |
| `href` | `href` | | `string` | `undefined` |
| `logo` | `logo` | | `string` | `undefined` |
| `message` | `message` | | `string` | `undefined` |
| `read` | `read` | | `boolean` | `false` |
12 changes: 12 additions & 0 deletions src/components/checkbox/d-checkbox.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
:host {
display: block;

}
ion-checkbox {
--checkbox-background: var(--on-alt);
--size: 48px;
--checkbox-background-checked: var(--accent)
}
ion-checkbox::part(container) {
border-radius: 0;
border: 2px solid;
border-color: var(--highlight);
--checkmark-color: var(--stroke);
}
2 changes: 1 addition & 1 deletion src/components/checkbox/d-checkbox.tsx
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ export class DCheckbox {
return (
<Host>
<d-vertical-stack>
<d-horizontal-stack>
<d-horizontal-stack class="items-center">
<ion-checkbox onIonChange={e => this.updateValue(e.detail.checked)} checked={this.checked}></ion-checkbox>
<div>
<slot />
2 changes: 1 addition & 1 deletion src/components/checkbox/test/d-checkbox.spec.tsx
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ describe('d-checkbox', () => {
<d-checkbox>
<mock:shadow-root>
<d-vertical-stack>
<d-horizontal-stack>
<d-horizontal-stack class="items-center">
<ion-checkbox></ion-checkbox>
<div>
<slot></slot>
734 changes: 700 additions & 34 deletions vscode-data.json

Large diffs are not rendered by default.