Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove drawer menu but where it should be #185

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: remove drawer menu but where it should be
phoebus-84 committed Dec 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4e4f4499c2af22d2858a4bc85534d23517959749
27 changes: 14 additions & 13 deletions src/components/header/d-header.tsx
Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@ export class DHeader {
@State() isSettingsOpen: boolean = false;
@Event() backButtonClick: EventEmitter<void>;


render() {
return (
<Host>
@@ -51,18 +50,20 @@ export class DHeader {
)}
</ion-toolbar>
</ion-header>
<ion-menu content-id="main-content">
<ion-header>
<ion-toolbar>
<ion-title>{this.settingsTitle}</ion-title>
</ion-toolbar>
</ion-header>
<ion-content>
<div class="px-4 py-2">
<slot name="settings"></slot>
</div>
</ion-content>
</ion-menu>
{this.settings && (
<ion-menu content-id="main-content">
<ion-header>
<ion-toolbar>
<ion-title>{this.settingsTitle}</ion-title>
</ion-toolbar>
</ion-header>
<ion-content>
<div class="px-4 py-2">
<slot name="settings"></slot>
</div>
</ion-content>
</ion-menu>
)}
</div>
</Host>
);
14 changes: 0 additions & 14 deletions src/components/header/test/d-header.spec.tsx
Original file line number Diff line number Diff line change
@@ -20,20 +20,6 @@ describe('d-header', () => {
</ion-title>
</ion-toolbar>
</ion-header>
<ion-menu content-id="main-content">
<ion-header>
<ion-toolbar>
<ion-title>
Settings
</ion-title>
</ion-toolbar>
</ion-header>
<ion-content>
<div class="px-4 py-2">
<slot name="settings"></slot>
</div>
</ion-content>
</ion-menu>
</div>
</mock:shadow-root>
</d-header>