Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account settings link no more disabled in settings menu #148

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix: account settings link no more disabled in settings menu #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00b952d
fix: account settings link no more disabled in settings menu
phoebus-84 Sep 2, 2024
cf206b1
test: settings menu update
phoebus-84 Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/settings-menu/d-settings-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class DSettingsMenu {
@Prop() version: string;
@Prop() developedBy: string;
@Prop() logoutCB: () => void;
@Prop() gotoAccountSettings: () => void;
@Prop() gotoLanguageSettings: () => void;
@Prop() openAppSettings: () => void;

Expand All @@ -25,7 +26,7 @@ export class DSettingsMenu {
<div class="flex flex-col justify-between">
<div class="flex flex-col gap-4">
<d-buttons-group>
<d-button aria-hidden size="large" disabled>
<d-button aria-hidden size="large" onClick={this.gotoAccountSettings}>
{this.accountSettings}
<d-icon icon="profile" slot="start" outline />
</d-button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/settings-menu/test/d-settings-menu.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ describe('d-settings-menu', () => {
<div class="flex flex-col justify-between">
<div class="flex flex-col gap-4">
<d-buttons-group>
<d-button aria-hidden="" disabled="" size="large">
<d-button aria-hidden="" size="large">
<d-icon icon="profile" outline="" slot="start"></d-icon>
</d-button>
<d-button disabled="" href="/" size="large">
Expand Down