Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middlewares): users should be able to execute a smart action on a smart collection #996

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

Thenkei
Copy link
Contributor

@Thenkei Thenkei commented Feb 22, 2023

Definition of Done

Issue: CU-#860q0f82b

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

#860q0f82b

@Thenkei Thenkei force-pushed the fix/conditional-smart-actions-on-smart-collection branch from ad96b46 to 4f0a615 Compare February 22, 2023 14:03
@Thenkei Thenkei force-pushed the fix/conditional-smart-actions-on-smart-collection branch from 4f0a615 to dfa0db5 Compare February 22, 2023 14:17
Copy link
Member

@arnaud-moncel arnaud-moncel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@codeclimate
Copy link

codeclimate bot commented Feb 22, 2023

Code Climate has analyzed commit dfa0db5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (70% is the threshold).

This pull request will bring the total coverage in the repository to 61.4%.

View more on Code Climate.

@Thenkei Thenkei self-assigned this Feb 22, 2023
@Thenkei Thenkei merged commit d325bfd into main Feb 22, 2023
@Thenkei Thenkei deleted the fix/conditional-smart-actions-on-smart-collection branch February 22, 2023 14:22
forest-bot added a commit that referenced this pull request Feb 22, 2023
## [10.1.10](v10.1.9...v10.1.10) (2023-02-22)

### Bug Fixes

* **middlewares:** users should be able to execute a smart action on a smart collection ([#996](#996)) ([d325bfd](d325bfd))
@forest-bot
Copy link
Member

🎉 This PR is included in version 10.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants